feat: Disable an ability to add temporal interactive filters#137
Merged
bprusinowski merged 1 commit intomainfrom Oct 13, 2021
Merged
Conversation
Collaborator
|
LGTM (nit: the second commit could be squashed with the first). |
jstcki
approved these changes
Oct 13, 2021
Contributor
jstcki
left a comment
jstcki
left a comment
There was a problem hiding this comment.
Looks good and works, as far as I can tell! Thanks, @bprusinowski!
bprusinowski
force-pushed
the
feat/disable-ability-to-add-temporal-interactive-filters
branch
from
9bb75a5 to
4605048
Compare
bprusinowski
deleted the
feat/disable-ability-to-add-temporal-interactive-filters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117.
As per conversation with @herrstucki, we decided to disable temporal interactive filters completely, as the whole approach probably needs some adjustments – both selects, inputs or sliders wouldn't be very convenient for selecting a single date when there is a lot of possible values.
This PR disables the ability to add temporal interactive filters when creating a chart – so the existing charts will still contain these filters for the time being.
In case there is a need to hide this type of filters in the current charts, let me know and I'll also introduce the changes.